test: fix consistent partition window test for urn-based extension API#166
Merged
tokoko merged 1 commit intoJun 3, 2026
Merged
Conversation
The ConsistentPartitionWindowRel test was written against the older uri-based extension API and broke after the migration to urns: - register_extension_dict() no longer accepts a `uri` keyword; the URN is supplied via the `urn:` field already present in the test YAML. - Plan.extension_uris was renamed to extension_urns. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
nielspardon
requested review from
andrew-coleman,
bestbeforetoday,
bvolpato and
tokoko
tokoko
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
mainCI is red because test collection fails ontests/builders/plan/test_consistent_partition_window.py, which cancels thewhole test matrix.
The test (added in #158) was written against the older
uri-based extensionAPI, but the codebase has since migrated to
urns. Two stale referencesremained:
register_extension_dict(..., uri=...): theurikeyword no longer exists,causing a
TypeErrorat collection time. The URN is now supplied via theurn:field already present in the test's YAML, so the kwarg is removed.extension_uris=list(lead_ee.extension_uris): this proto field was renamed toextension_urns(already present on the preceding line). This second errorwas masked by the collection failure.
Test plan
pytest tests/builders/plan/test_consistent_partition_window.py-> 8 passed